feat(eips): Indexed Blob Hash #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
clabby
approved these changes
Oct 19, 2024
refcell
force-pushed
the
rf/feat/indexed-blob-hash
branch
from
8f944b6
to
04e5e6c
Compare
mattsse
reviewed
Oct 19, 2024
mattsse
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alloy's EIP 4844 Blob Sidecar provided a way to verify blobs given the indexed blob hash. Previously, this argument was the EIP 1898 NumHash construct, which doesn't translate to beacon. The indexed blob hash we actually want to accept is a net new type with an index and blob hash, instead of the block number and hash from the
NumHashtype.This PR introduces that type, and changes the
verify_blobmethod to accept theIndexedBlobHash.